From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takuya Yoshikawa <yoshikawa.takuya@oss.ntt.co.jp>
Subject: Re: [PATCH 2/2 rebased] KVM: MMU: Introduce a helper to access lpage_info
Date: Mon, 06 Dec 2010 16:55:59 +0900
Message-ID: <4CFC970F.5030702@oss.ntt.co.jp>
References: <20101206011133.e5487868.takuya.yoshikawa@gmail.com> <20101206011354.1321d3fa.takuya.yoshikawa@gmail.com> <4CFC84A6.4060006@cn.fujitsu.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Takuya Yoshikawa <takuya.yoshikawa@gmail.com>, avi@redhat.com,
	mtosatti@redhat.com, kvm@vger.kernel.org
To: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from serv2.oss.ntt.co.jp ([222.151.198.100]:42156 "EHLO
	serv2.oss.ntt.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751424Ab0LFHxf (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 6 Dec 2010 02:53:35 -0500
In-Reply-To: <4CFC84A6.4060006@cn.fujitsu.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

(2010/12/06 15:37), Xiao Guangrong wrote:
> On 12/06/2010 12:13 AM, Takuya Yoshikawa wrote:
>> From: Takuya Yoshikawa<yoshikawa.takuya@oss.ntt.co.jp>
>>
>> Index calculation to access lpage_info appears three times.
>> A helper is worthwhile.
>>
>
> Why not get lpage_info instead of index in the helper?

Seems a better way! I didn't think about it.

I'll check and resend [2/2] if it's OK.

Thanks,
   Takuya