Re: [PATCH v4 1/3] KVM: MMU: rename 'no_apf' to 'prefault'

Gleb Natapov
2010-12-06T09:32:08Z

On Fri, Dec 03, 2010 at 06:30:55PM -0200, Marcelo Tosatti wrote:
> On Thu, Dec 02, 2010 at 05:44:43PM +0800, Xiao Guangrong wrote:
> > It's the speculative path if 'no_apf = 1' and we will specially handle this
> > speculative path in the later patch, so 'prefault' is better to fit the sense
> >
> > Signed-off-by: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
> > ---
> > arch/x86/include/asm/kvm_host.h | 3 ++-
> > arch/x86/kvm/mmu.c | 18 +++++++++---------
> > arch/x86/kvm/paging_tmpl.h | 4 ++--
> > 3 files changed, 13 insertions(+), 12 deletions(-)
>
> Looks good to me. Avi, Gleb?
Looks mostly OK to me too. Third patch check only cr3 but cr4 & efer can
affect paging too, but since page fault is not injected anyway in case
of an error and for most guests cr4 & efer shouldn't change frequently I
guess this is OK.

--
Gleb.