From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 2/2 rebased] KVM: MMU: Introduce a helper to access lpage_info Date: Mon, 06 Dec 2010 15:07:50 +0200 Message-ID: <4CFCE026.9060708@redhat.com> References: <20101206011133.e5487868.takuya.yoshikawa@gmail.com> <20101206011354.1321d3fa.takuya.yoshikawa@gmail.com> <4CFC84A6.4060006@cn.fujitsu.com> <4CFC970F.5030702@oss.ntt.co.jp> <4CFCA584.2030609@oss.ntt.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Xiao Guangrong , Takuya Yoshikawa , mtosatti@redhat.com, kvm@vger.kernel.org To: Takuya Yoshikawa Return-path: Received: from mx1.redhat.com ([209.132.183.28]:19112 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750823Ab0LFNIB (ORCPT ); Mon, 6 Dec 2010 08:08:01 -0500 In-Reply-To: <4CFCA584.2030609@oss.ntt.co.jp> Sender: kvm-owner@vger.kernel.org List-ID: On 12/06/2010 10:57 AM, Takuya Yoshikawa wrote: > (2010/12/06 16:55), Takuya Yoshikawa wrote: >> (2010/12/06 15:37), Xiao Guangrong wrote: >>> On 12/06/2010 12:13 AM, Takuya Yoshikawa wrote: >>>> From: Takuya Yoshikawa >>>> >>>> Index calculation to access lpage_info appears three times. >>>> A helper is worthwhile. >>>> >>> >>> Why not get lpage_info instead of index in the helper? >> >> Seems a better way! I didn't think about it. >> >> I'll check and resend [2/2] if it's OK. >> > > Sadly, the structure of lpage_info has no name. > Well, you can give it a name. Meanwhile I've applied patch 1, thanks. -- error compiling committee.c: too many arguments to function