From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH v4 3/3] KVM: MMU: retry #PF for softmmu Date: Mon, 06 Dec 2010 15:17:36 +0200 Message-ID: <4CFCE270.1080500@redhat.com> References: <4CF76A8B.2040102@cn.fujitsu.com> <4CF76B06.6050708@cn.fujitsu.com> <4CFCB150.40202@redhat.com> <4CFCB983.6020503@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , Gleb Natapov , LKML , KVM To: Xiao Guangrong Return-path: In-Reply-To: <4CFCB983.6020503@cn.fujitsu.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 12/06/2010 12:22 PM, Xiao Guangrong wrote: > Hi Avi, > > On 12/06/2010 05:48 PM, Avi Kivity wrote: > > On 12/02/2010 11:46 AM, Xiao Guangrong wrote: > >> Retry #PF for softmmu only when the current vcpu has the same cr3 as > >> the time > >> when #PF occurs > >> > >> Changelog: > >> Just compare cr3 value since It's harmless to instantiate an spte > >> for an > >> unused translation from Marcelo's comment > >> > > > > It's not harmless. We could be in a different process, so we have to > > re-fetch the gpte. Or we could have switched from one nested guest to > > another. > > > > But it does this in this patch: re-walk guest page table and fixes guest's > shadow page (not use any info when apf is occurred) Right. Please resend without the walk_addr() changes. While they're correct, I'd like to keep that part simpler. -- error compiling committee.c: too many arguments to function