From: Avi Kivity <avi@redhat.com>
To: vatsa@linux.vnet.ibm.com
Cc: Anthony Liguori <aliguori@us.ibm.com>,
kvm@vger.kernel.org, Marcelo Tosatti <mtosatti@redhat.com>,
Chris Wright <chrisw@sous-sol.org>
Subject: Re: [PATCH] kvm-vmx: add module parameter to avoid trapping HLT instructions (v4)
Date: Mon, 06 Dec 2010 15:43:56 +0200 [thread overview]
Message-ID: <4CFCE89C.10904@redhat.com> (raw)
In-Reply-To: <20101206133952.GE440@linux.vnet.ibm.com>
On 12/06/2010 03:39 PM, Srivatsa Vaddagiri wrote:
> > >Also, just curious how this would work for idle vcpus that use mwait rather
> > >than hlt.
> >
> > We don't expose mwait to the guest (emulating mwait is very expensive).
>
> We seem to be queuing an exception upon mwait (EXIT_REASON_MWAIT_INSTRUCTION
> being handled by a handle_invalid_op()). Does that kill the guest?
It sends a #UD, which tells the guest mwait isn't supported. Usually
the guest will fall on its sword at this point, but that's not mandated.
--
error compiling committee.c: too many arguments to function
prev parent reply other threads:[~2010-12-06 13:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-04 14:43 [PATCH] kvm-vmx: add module parameter to avoid trapping HLT instructions (v4) Anthony Liguori
2010-12-05 16:55 ` Srivatsa Vaddagiri
2010-12-06 13:27 ` Avi Kivity
2010-12-06 13:39 ` Srivatsa Vaddagiri
2010-12-06 13:43 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CFCE89C.10904@redhat.com \
--to=avi@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=chrisw@sous-sol.org \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=vatsa@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox