From: Avi Kivity <avi@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
kvm@vger.kernel.org, Chris Wright <chrisw@sous-sol.org>,
Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com>
Subject: Re: [PATCH] kvm-vmx: add module parameter to avoid trapping HLT instructions (v2)
Date: Mon, 06 Dec 2010 16:33:03 +0200 [thread overview]
Message-ID: <4CFCF41F.4000905@redhat.com> (raw)
In-Reply-To: <4CFCED32.3020803@codemonkey.ws>
On 12/06/2010 04:03 PM, Anthony Liguori wrote:
>> It does. Good, it simplifies the patch.
>
>
> Any ideas if the unit test framework can be used to validate this?
> The behavior makes perfect sense but I wanted an excuse to play around
> with it :-)
>
Not the user space one. The exit we're interested in is external
interrupt, and that one isn't delivered to userspace.
I guess you could have a loop
1: hlt
jmp 1b
and enter it programming a timer to something close, and examine the
vcpu state afterwards. However you don't propagate the VMCS halted
state to the corresponding kvm state, so there's no way to test it. (a
minor bug in your patch)
> Not sure if there's a way to validate VMCS state after a hand crafted
> exit.
>
KVM_GET_REGS and friends.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2010-12-06 14:33 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-02 13:59 [PATCH] kvm-vmx: add module parameter to avoid trapping HLT instructions (v2) Anthony Liguori
2010-12-02 14:39 ` lidong chen
2010-12-02 15:23 ` Anthony Liguori
2010-12-02 15:23 ` Anthony Liguori
2010-12-03 9:38 ` Avi Kivity
2010-12-03 11:12 ` Srivatsa Vaddagiri
2010-12-03 23:28 ` Anthony Liguori
2010-12-02 17:37 ` Marcelo Tosatti
2010-12-02 19:07 ` Anthony Liguori
2010-12-02 20:12 ` Marcelo Tosatti
2010-12-02 20:51 ` Anthony Liguori
2010-12-03 9:36 ` Avi Kivity
2010-12-03 22:45 ` Anthony Liguori
2010-12-04 8:13 ` Avi Kivity
2010-12-04 13:30 ` Anthony Liguori
2010-12-06 8:28 ` Avi Kivity
2010-12-06 8:35 ` Avi Kivity
2010-12-06 13:58 ` Anthony Liguori
2010-12-06 14:01 ` Avi Kivity
2010-12-06 14:02 ` Avi Kivity
2010-12-06 14:08 ` Anthony Liguori
2010-12-06 14:14 ` Gleb Natapov
2010-12-06 14:03 ` Anthony Liguori
2010-12-06 14:33 ` Avi Kivity [this message]
2010-12-06 15:07 ` Anthony Liguori
2010-12-06 15:16 ` Avi Kivity
2010-12-06 16:21 ` Anthony Liguori
2010-12-06 16:30 ` Avi Kivity
2010-12-06 16:33 ` Anthony Liguori
2010-12-03 12:40 ` Gleb Natapov
2010-12-03 23:31 ` Anthony Liguori
2010-12-03 22:42 ` Anthony Liguori
2010-12-04 8:16 ` Avi Kivity
2010-12-04 13:48 ` Anthony Liguori
2010-12-06 8:32 ` Avi Kivity
2010-12-02 19:14 ` Chris Wright
2010-12-02 20:25 ` Anthony Liguori
2010-12-02 20:40 ` Chris Wright
2010-12-02 20:40 ` Marcelo Tosatti
2010-12-02 21:07 ` Chris Wright
2010-12-02 22:37 ` Anthony Liguori
2010-12-03 2:42 ` Chris Wright
2010-12-03 3:21 ` Anthony Liguori
2010-12-03 3:44 ` Chris Wright
2010-12-03 14:25 ` Anthony Liguori
2010-12-02 22:27 ` Anthony Liguori
2010-12-03 22:49 ` Anthony Liguori
2010-12-04 5:43 ` Srivatsa Vaddagiri
2010-12-03 9:40 ` Avi Kivity
2010-12-03 11:21 ` Srivatsa Vaddagiri
2010-12-03 11:57 ` Srivatsa Vaddagiri
2010-12-03 16:27 ` Srivatsa Vaddagiri
2010-12-03 17:29 ` Chris Wright
2010-12-03 17:33 ` Srivatsa Vaddagiri
2010-12-04 8:18 ` Avi Kivity
2010-12-03 17:57 ` Srivatsa Vaddagiri
2010-12-03 17:58 ` Chris Wright
2010-12-03 18:07 ` Anthony Liguori
2010-12-03 18:12 ` Srivatsa Vaddagiri
2010-12-04 8:19 ` Avi Kivity
2010-12-03 18:20 ` Chris Wright
2010-12-03 18:55 ` Anthony Liguori
2010-12-03 18:10 ` Marcelo Tosatti
2010-12-03 18:24 ` Marcelo Tosatti
2010-12-03 17:28 ` Chris Wright
2010-12-03 17:36 ` Srivatsa Vaddagiri
2010-12-03 17:38 ` Chris Wright
2010-12-03 17:43 ` Srivatsa Vaddagiri
2010-12-03 17:47 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CFCF41F.4000905@redhat.com \
--to=avi@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=chrisw@sous-sol.org \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=vatsa@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox