Re: [PATCH] KVM: SVM: Add xsetbv intercept

Avi Kivity
2010-12-06T16:10:46Z

On 12/03/2010 06:42 PM, Joerg Roedel wrote:
> This patch implements the xsetbv intercept to the AMD part
> of KVM. This makes AVX usable in a save way for the guest on
> AVX capable AMD hardware.
> The patch is tested by using AVX in the guest and host in
> parallel and checking for data corruption. I also used the
> KVM xsave unit-tests and they all pass.
>

That is really strange. You didn't need to do anything to get cpuid.avx
recognized. So running an older kvm on newer hardware will happily
expose avx even though it's not supported.

We screwed up - we should have made cpuid.avx dependent on vendor support.

The patch itself looks fine, I just want to understand this point first.

--
error compiling committee.c: too many arguments to function