From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [PATCH] kvm-vmx: add module parameter to avoid trapping HLT instructions (v2) Date: Mon, 06 Dec 2010 10:21:03 -0600 Message-ID: <4CFD0D6F.1030509@codemonkey.ws> References: <1291298357-5695-1-git-send-email-aliguori@us.ibm.com> <20101202173733.GA26342@amt.cnet> <4CF7EE63.40209@codemonkey.ws> <20101202201223.GA31316@amt.cnet> <4CF806E7.1090404@codemonkey.ws> <4CF8BA34.1000508@redhat.com> <4CF9730C.7040904@codemonkey.ws> <4CF9F83C.5040807@redhat.com> <4CFA425D.3010100@codemonkey.ws> <4CFC9EC6.3010108@redhat.com> <4CFCA06B.9030406@redhat.com> <4CFCEBE9.2010107@codemonkey.ws> <4CFCECA6.3030007@redhat.com> <4CFCED32.3020803@codemonkey.ws> <4CFCF41F.4000905@redhat.com> <4CFCFC19.3010502@codemonkey.ws> <4CFCFE31.8020406@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm@vger.kernel.org, Chris Wright , Srivatsa Vaddagiri To: Avi Kivity Return-path: Received: from mail-yw0-f46.google.com ([209.85.213.46]:47345 "EHLO mail-yw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751821Ab0LFQVW (ORCPT ); Mon, 6 Dec 2010 11:21:22 -0500 Received: by ywl5 with SMTP id 5so6067745ywl.19 for ; Mon, 06 Dec 2010 08:21:21 -0800 (PST) In-Reply-To: <4CFCFE31.8020406@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 12/06/2010 09:16 AM, Avi Kivity wrote: > On 12/06/2010 05:07 PM, Anthony Liguori wrote: >>> Not the user space one. The exit we're interested in is external >>> interrupt, and that one isn't delivered to userspace. >>> >>> I guess you could have a loop >>> >>> 1: hlt >>> jmp 1b >>> >>> and enter it programming a timer to something close, and examine the >>> vcpu state afterwards. However you don't propagate the VMCS halted >>> state to the corresponding kvm state, so there's no way to test it. >>> (a minor bug in your patch) >> >> >> The activity state doesn't get propagated at all to the kvm state. >> Can we get into a non-zero activity state today (either SHUTDOWN or >> WAIT_SIPI)? > > No, right now we intercept SHUTDOWN (and turn it back, in qemu, into a > RESET), and we emulate all the SIPI stuff. We also intercepted HLT so > we couldn't get that activity state either. Ok, looks like I need to make this per-VM and use a CAP along with an interface to enable it to ensure that userspace to ensure it gets saved/restored appropriately. I'll rework it. Regards, Anthony Liguori