From: Avi Kivity <avi@redhat.com>
To: Andre Przywara <andre.przywara@amd.com>
Cc: kvm@vger.kernel.org, mtosatti@redhat.com
Subject: Re: [PATCH 3/5] kvm/svm: enhance mov DR intercept handler
Date: Tue, 07 Dec 2010 15:25:22 +0200 [thread overview]
Message-ID: <4CFE35C2.3050301@redhat.com> (raw)
In-Reply-To: <1291719586-22533-4-git-send-email-andre.przywara@amd.com>
On 12/07/2010 12:59 PM, Andre Przywara wrote:
> Newer SVM implementations provide the GPR number in the VMCB, so
> that the emulation path is no longer necesarry to handle debug
> register access intercepts. Implement the handling in svm.c and
> use it when the info is provided.
>
>
>
> +static int dr_interception(struct vcpu_svm *svm)
> +{
> + int reg, dr;
> + unsigned long val;
> +
> + if (!boot_cpu_has(SVM_FEATURE_DECODE_ASSIST))
> + return emulate_on_interception(svm);
> +
> + reg = svm->vmcb->control.exit_info_1& SVM_EXITINFO_REG_MASK;
> + dr = svm->vmcb->control.exit_code - SVM_EXIT_READ_DR0;
> +
> + if (dr> 15) { /* mov to DRn */
> + val = kvm_register_read(&svm->vcpu, reg);
> + kvm_set_dr(&svm->vcpu, dr - 16, val);
> + } else {
> + kvm_get_dr(&svm->vcpu, dr,&val);
> + kvm_register_write(&svm->vcpu, reg, val);
> + }
> +
> + skip_emulated_instruction(&svm->vcpu);
> + return 1;
> +}
Again, need to handle faults.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2010-12-07 13:25 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-07 10:59 [PATCH 0/5] kvm/svm: implement new DecodeAssist features Andre Przywara
2010-12-07 10:59 ` [PATCH 1/5] kvm/svm: add new SVM feature bit names Andre Przywara
2010-12-07 10:59 ` [PATCH 2/5] kvm/svm: enhance MOV CR intercept handler Andre Przywara
2010-12-07 13:24 ` Avi Kivity
2010-12-07 14:30 ` Andre Przywara
2010-12-07 14:41 ` Avi Kivity
2010-12-07 10:59 ` [PATCH 3/5] kvm/svm: enhance mov DR " Andre Przywara
2010-12-07 11:02 ` Alexander Graf
2010-12-07 13:14 ` Avi Kivity
2010-12-07 13:25 ` Avi Kivity [this message]
2010-12-07 10:59 ` [PATCH 4/5] kvm/svm: implement enhanced INVLPG intercept Andre Przywara
2010-12-07 13:27 ` Avi Kivity
2010-12-07 10:59 ` [PATCH 5/5] kvm/svm: copy instruction bytes from VMCB Andre Przywara
2010-12-07 13:33 ` Avi Kivity
-- strict thread matches above, loose matches on Subject: below --
2010-12-10 13:51 [PATCH -v2 0/5] kvm/svm: implement new DecodeAssist features Andre Przywara
2010-12-10 13:51 ` [PATCH 3/5] kvm/svm: enhance mov DR intercept handler Andre Przywara
2010-12-13 12:14 ` Avi Kivity
2010-12-16 12:07 ` Andre Przywara
2010-12-16 12:48 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CFE35C2.3050301@redhat.com \
--to=avi@redhat.com \
--cc=andre.przywara@amd.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox