From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH] KVM: Fix OSXSAVE after migration
Date: Wed, 08 Dec 2010 12:33:43 +0200
Message-ID: <4CFF5F07.6080403@redhat.com>
References: <1291776583-9979-1-git-send-email-sheng@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Marcelo Tosatti <mtosatti@redhat.com>, kvm@vger.kernel.org,
	stable@kernel.org
To: Sheng Yang <sheng@linux.intel.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:2013 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753802Ab0LHKdt (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 8 Dec 2010 05:33:49 -0500
In-Reply-To: <1291776583-9979-1-git-send-email-sheng@linux.intel.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 12/08/2010 04:49 AM, Sheng Yang wrote:
> CPUID's OSXSAVE is a mirror of CR4.OSXSAVE bit. We need to update the CPUID
> after migration.
>

Applied, thanks.

> @@ -5585,6 +5585,8 @@ int kvm_arch_vcpu_ioctl_set_sregs(struct kvm_vcpu *vcpu,
>
>   	mmu_reset_needed |= kvm_read_cr4(vcpu) != sregs->cr4;
>   	kvm_x86_ops->set_cr4(vcpu, sregs->cr4);
> +	if (sregs->cr4&  X86_CR4_OSXSAVE)
> +		update_cpuid(vcpu);
>   	if (!is_long_mode(vcpu)&&  is_pae(vcpu)) {
>   		load_pdptrs(vcpu, vcpu->arch.walk_mmu, vcpu->arch.cr3);
>   		mmu_reset_needed = 1;


We really should use kvm_set_crX() here.

-- 
error compiling committee.c: too many arguments to function