Re: [PATCH v2 0/5] Extra capabilities for device assignment

[Avi Kivity <avi@redhat.com>]

On 12/09/2010 05:13 PM, Markus Armbruster wrote:
> Avi Kivity<avi@redhat.com>  writes:
>
> >  On 12/06/2010 06:43 PM, Alex Williamson wrote:
> >>  On Mon, 2010-12-06 at 18:34 +0200, Avi Kivity wrote:
> >>  >   On 12/06/2010 06:21 PM, Alex Williamson wrote:
> >>  >   >   v2:
> >>  >   >     - Reimplement 2/5 to remove more cruft
> >>  >   >
> >>  >   >   v1:
> >>  >   >
> >>  >   >   Now that we've got PCI capabilities cleaned up and device assignment
> >>  >   >   using them, we can add more capabilities to be guest visible.  This
> >>  >   >   adds minimal PCI Express, PCI-X, and Power Management, along with
> >>  >   >   direct passthrough Vital Product Data and Vendor Specific capabilities.
> >>  >   >   With this, devices like tg3, bnx2, vxge, and potentially quite a few
> >>  >   >   others that didn't work previously should be happier.  Thanks,
> >>  >   >
> >>  >
> >>  >   Applied, thanks.  EFAULT is not the best error return, though.
> >>
> >>  Do you prefer EBUSY?  Bad address seemed appropriate here, but I'm not
> >>  attached to it.  Feel free to change it, or I can send a follow-up.
> >>  Thanks,
> >
> >  EBUSY isn't descriptive either, but EFAULT is wrong, it's the syscall
> >  equivalent of a SEGV, which hasn't happened here.  How I hate errno.h.
>
> EEXIST?  EINVAL?

I guess EINVAL is best ("go read the source code").

-- 
error compiling committee.c: too many arguments to function