Re: [PATCH v2 2/2] qemu,qmp: convert do_inject_nmi() to QObject, QError

Luiz Capitulino
2010-12-10T11:20:45Z

On Fri, 10 Dec 2010 14:36:08 +0800
Lai Jiangshan <laijs@cn.fujitsu.com> wrote:

> +SQMP
> +inject_nmi
> +----------
> +
> +Inject an NMI on the given CPU (x86 only).
> +
> +Arguments:
> +
> +- "cpu_index": the index of the CPU to be injected NMI (json-int)
> +
> +Example:
> +
> +-> { "execute": "inject_nmi", "arguments": { "cpu_index": 0 } }
> +<- { "return": {} }
> +
> +EQMP
> +

Avi, Anthony, can you please review this? Do we expect some kind of ack from
the guest? Do we expect it respond in some way?

Also note that the current series defines only one error condition: invalid
cpu index. Can this fail in other ways?