Re: [RFC PATCH 2/3] sched: add yield_to function

Peter Zijlstra
2010-12-03T21:30:42Z

On Fri, 2010-12-03 at 13:27 -0500, Rik van Riel wrote:
> > Should these details all be in sched_fair? Seems like the wrong layer
> > here. And would that condition go the other way? If new vruntime is
> > smaller than min, then it becomes new cfs_rq->min_vruntime?
>
> That would be nice. Unfortunately, EXPORT_SYMBOL() does
> not seem to work right from sched_fair.c, which is included
> from sched.c instead of being built from the makefile!

I'm not quite sure why that is, but I kinda like that, the policy
implementation should never export stuff.

Code outside the scheduler cannot ever know the policy of a task, hence
policy specific exports are bad.

A generic export with policy implementations (like the
sched_class::yield_to() proposal) are the proper way.