From: Avi Kivity <avi@redhat.com>
To: Andre Przywara <andre.przywara@amd.com>
Cc: kvm@vger.kernel.org, mtosatti@redhat.com
Subject: Re: [PATCH] kvm: cleanup CR8 handling
Date: Mon, 13 Dec 2010 14:08:20 +0200 [thread overview]
Message-ID: <4D060CB4.9000207@redhat.com> (raw)
In-Reply-To: <1291807635-3583-1-git-send-email-andre.przywara@amd.com>
On 12/08/2010 01:27 PM, Andre Przywara wrote:
> The handling of CR8 writes in KVM is currently somewhat cumbersome.
> This patch makes it look like the other CR register handlers
> and fixes a possible issue in VMX, where the RIP would be incremented
> despite an injected #GP.
>
> unsigned long kvm_get_cr8(struct kvm_vcpu *vcpu)
> @@ -4104,7 +4098,7 @@ static int emulator_set_cr(int cr, unsigned long val, struct kvm_vcpu *vcpu)
> res = kvm_set_cr4(vcpu, mk_cr_64(kvm_read_cr4(vcpu), val));
> break;
> case 8:
> - res = __kvm_set_cr8(vcpu, val& 0xfUL);
> + res = kvm_set_cr8(vcpu, val);
> break;
> default:
> vcpu_printf(vcpu, "%s: unexpected cr %u\n", __func__, cr);
Why drop the mask?
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2010-12-13 12:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-08 11:27 [PATCH] kvm: cleanup CR8 handling Andre Przywara
2010-12-13 12:08 ` Avi Kivity [this message]
2010-12-21 10:07 ` Andre Przywara
2010-12-21 10:56 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D060CB4.9000207@redhat.com \
--to=avi@redhat.com \
--cc=andre.przywara@amd.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox