From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH 3/5] kvm/svm: enhance mov DR intercept handler
Date: Mon, 13 Dec 2010 14:14:56 +0200
Message-ID: <4D060E40.60308@redhat.com>
References: <1291989088-1380-1-git-send-email-andre.przywara@amd.com> <1291989088-1380-4-git-send-email-andre.przywara@amd.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: mtosatti@redhat.com, kvm@vger.kernel.org
To: Andre Przywara <andre.przywara@amd.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:32046 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1757174Ab0LMMPA (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 13 Dec 2010 07:15:00 -0500
In-Reply-To: <1291989088-1380-4-git-send-email-andre.przywara@amd.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 12/10/2010 03:51 PM, Andre Przywara wrote:
> Newer SVM implementations provide the GPR number in the VMCB, so
> that the emulation path is no longer necesarry to handle debug
> register access intercepts. Implement the handling in svm.c and
> use it when the info is provided.
>
> +
> +	if (!err)
> +		skip_emulated_instruction(&svm->vcpu);
> +	else
> +		kvm_inject_gp(&svm->vcpu, 0);
> +

This repeats, how about using complete_insn_gp()?

-- 
error compiling committee.c: too many arguments to function