From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH 1/2] KVM: MMU: don't make direct sp read-only if !map_writable
Date: Tue, 14 Dec 2010 10:56:19 +0200
Message-ID: <4D073133.1020709@redhat.com>
References: <4D05F5F6.3070909@cn.fujitsu.com> <4D05F62D.9040308@redhat.com> <4D06CE19.9000908@cn.fujitsu.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
	LKML <linux-kernel@vger.kernel.org>, KVM <kvm@vger.kernel.org>
To: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <4D06CE19.9000908@cn.fujitsu.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org

On 12/14/2010 03:53 AM, Xiao Guangrong wrote:
> >  I just sent a patch to fix this in a different way, please review it.
> >
>
> Your patch is good for me, please ignore this one :-)
>
> Umm, do we need move "access&= ~ACC_WRITE_MASK" into set_spte() then
> can remove the same code in the caller?

I guess set_spte() is the better place for this.

-- 
error compiling committee.c: too many arguments to function