From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH v4 2/2] RAM API: Make use of it for x86 PC Date: Tue, 14 Dec 2010 11:18:25 +0200 Message-ID: <4D073661.8010307@redhat.com> References: <20101213212059.2472.17879.stgit@s20.home> <20101213212436.2472.16686.stgit@s20.home> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: qemu-devel@nongnu.org, anthony@codemonkey.ws, blauwirbel@gmail.com, kvm@vger.kernel.org To: Alex Williamson Return-path: Received: from mx1.redhat.com ([209.132.183.28]:38404 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755822Ab0LNJSh (ORCPT ); Tue, 14 Dec 2010 04:18:37 -0500 In-Reply-To: <20101213212436.2472.16686.stgit@s20.home> Sender: kvm-owner@vger.kernel.org List-ID: On 12/13/2010 11:24 PM, Alex Williamson wrote: > Register the actual VM RAM using the new API > > > @@ -913,14 +913,11 @@ void pc_memory_init(ram_addr_t ram_size, > /* allocate RAM */ > ram_addr = qemu_ram_alloc(NULL, "pc.ram", > below_4g_mem_size + above_4g_mem_size); > - cpu_register_physical_memory(0, 0xa0000, ram_addr); > - cpu_register_physical_memory(0x100000, > - below_4g_mem_size - 0x100000, > - ram_addr + 0x100000); > + ram_register(0, below_4g_mem_size, ram_addr); > What's the impact of this? Won't it conflict with BIOS memory registration? What about VGA? In terms of patch hygiene, it should be in a separate patch titled "register 0xa0000-0x100000 as RAM" or something. It's a much more drastic change than making use of the new RAM API. -- error compiling committee.c: too many arguments to function