From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 2/3] KVM: Centralize slots_lock aquisition during KVM_CREATE_IRQCHIP Date: Thu, 16 Dec 2010 11:55:11 +0200 Message-ID: <4D09E1FF.9040408@redhat.com> References: <20101216013917.a8a8bab9.takuya.yoshikawa@gmail.com> <20101216014326.9210211a.takuya.yoshikawa@gmail.com> <4D09D7DF.3010209@redhat.com> <4D09DBFB.1080103@oss.ntt.co.jp> <4D09DD3F.5070408@redhat.com> <4D09E036.2090705@oss.ntt.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Takuya Yoshikawa , mtosatti@redhat.com, kvm@vger.kernel.org, kvm-ia64@vger.kernel.org To: Takuya Yoshikawa Return-path: Received: from mx1.redhat.com ([209.132.183.28]:6671 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753964Ab0LPJzS (ORCPT ); Thu, 16 Dec 2010 04:55:18 -0500 In-Reply-To: <4D09E036.2090705@oss.ntt.co.jp> Sender: kvm-owner@vger.kernel.org List-ID: On 12/16/2010 11:47 AM, Takuya Yoshikawa wrote: >> They're under srcu now, the comments are outdated. >> >> We used to have slots_lock be a rwsem, taken for read or write as >> necessary. Now we use srcu for read, and the slots_lock mutex + >> synchronize_srcu for write. >> > > > Ah, would you mind updating the comments? > - or just removing outdated ones? > > Fixing the comments would be good. > I will reread these locking based on your answer! > One day I'll write Documentation/kvm/locking.txt, so it could get outdated as well. -- error compiling committee.c: too many arguments to function