From: Andre Przywara <andre.przywara@amd.com>
To: Avi Kivity <avi@redhat.com>
Cc: "mtosatti@redhat.com" <mtosatti@redhat.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: Re: [PATCH 3/5] kvm/svm: enhance mov DR intercept handler
Date: Thu, 16 Dec 2010 13:07:34 +0100 [thread overview]
Message-ID: <4D0A0106.5080005@amd.com> (raw)
In-Reply-To: <4D060E40.60308@redhat.com>
Avi Kivity wrote:
> On 12/10/2010 03:51 PM, Andre Przywara wrote:
>> Newer SVM implementations provide the GPR number in the VMCB, so
>> that the emulation path is no longer necesarry to handle debug
>> register access intercepts. Implement the handling in svm.c and
>> use it when the info is provided.
>>
>> +
>> + if (!err)
>> + skip_emulated_instruction(&svm->vcpu);
>> + else
>> + kvm_inject_gp(&svm->vcpu, 0);
>> +
>
> This repeats, how about using complete_insn_gp()?
Do you want this to be in x86.c? We could use
kvm_x86_ops->skip_emulated_instruction.
Also shall I look for more similarities in the [CD]R intercept handling
code between VMX and SVM? The switch responsible for actually reading
and writing the regs is very similar. I could also try to merge this
with the functionality in the emulator (if that works, haven't checked)
Regards,
Andre.
--
Andre Przywara
AMD-Operating System Research Center (OSRC), Dresden, Germany
Tel: +49 351 448-3567-12
next prev parent reply other threads:[~2010-12-16 12:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-10 13:51 [PATCH -v2 0/5] kvm/svm: implement new DecodeAssist features Andre Przywara
2010-12-10 13:51 ` [PATCH 1/5] kvm/svm: add new SVM feature bit names Andre Przywara
2010-12-10 13:51 ` [PATCH 2/5] kvm/svm: enhance MOV CR intercept handler Andre Przywara
2010-12-13 12:13 ` Avi Kivity
2010-12-20 11:56 ` Marcelo Tosatti
2010-12-20 13:20 ` Andre Przywara
2010-12-10 13:51 ` [PATCH 3/5] kvm/svm: enhance mov DR " Andre Przywara
2010-12-13 12:14 ` Avi Kivity
2010-12-16 12:07 ` Andre Przywara [this message]
2010-12-16 12:48 ` Avi Kivity
2010-12-10 13:51 ` [PATCH 4/5] kvm/svm: implement enhanced INVLPG intercept Andre Przywara
2010-12-10 13:51 ` [PATCH 5/5] kvm/svm: copy instruction bytes from VMCB Andre Przywara
2010-12-13 12:24 ` Avi Kivity
-- strict thread matches above, loose matches on Subject: below --
2010-12-07 10:59 [PATCH 0/5] kvm/svm: implement new DecodeAssist features Andre Przywara
2010-12-07 10:59 ` [PATCH 3/5] kvm/svm: enhance mov DR intercept handler Andre Przywara
2010-12-07 11:02 ` Alexander Graf
2010-12-07 13:14 ` Avi Kivity
2010-12-07 13:25 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D0A0106.5080005@amd.com \
--to=andre.przywara@amd.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox