Re: [PATCH 3/5] kvm/svm: enhance mov DR intercept handler

[Avi Kivity <avi@redhat.com>]

On 12/16/2010 02:07 PM, Andre Przywara wrote:
> Avi Kivity wrote:
>> On 12/10/2010 03:51 PM, Andre Przywara wrote:
>>> Newer SVM implementations provide the GPR number in the VMCB, so
>>> that the emulation path is no longer necesarry to handle debug
>>> register access intercepts. Implement the handling in svm.c and
>>> use it when the info is provided.
>>>
>>> +
>>> +    if (!err)
>>> +        skip_emulated_instruction(&svm->vcpu);
>>> +    else
>>> +        kvm_inject_gp(&svm->vcpu, 0);
>>> +
>>
>> This repeats, how about using complete_insn_gp()?
> Do you want this to be in x86.c?

Yes.

> We could use kvm_x86_ops->skip_emulated_instruction.
> Also shall I look for more similarities in the [CD]R intercept 
> handling code between VMX and SVM? The switch responsible for actually 
> reading and writing the regs is very similar. I could also try to 
> merge this with the functionality in the emulator (if that works, 
> haven't checked)
>

Let's get DecodeAssist merged first, and do more unification afterwards.

-- 
error compiling committee.c: too many arguments to function