From: Randy Dunlap <randy.dunlap@oracle.com>
To: Avi Kivity <avi@redhat.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>, kvm@vger.kernel.org
Subject: Re: [PATCH] KVM: VMX: Correct asm constraint in vmcs_load()
Date: Mon, 20 Dec 2010 08:56:02 -0800 [thread overview]
Message-ID: <4D0F8AA2.3010301@oracle.com> (raw)
In-Reply-To: <1292835996-7274-1-git-send-email-avi@redhat.com>
On 12/20/10 01:06, Avi Kivity wrote:
> 'error' is byte sized, so use a byte register constraint.
Hm, OK, but I still get the same build error.
> Signed-off-by: Avi Kivity <avi@redhat.com>
> ---
> arch/x86/kvm/vmx.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> index c195260..a92fdde 100644
> --- a/arch/x86/kvm/vmx.c
> +++ b/arch/x86/kvm/vmx.c
> @@ -488,7 +488,7 @@ static void vmcs_load(struct vmcs *vmcs)
> u8 error;
>
> asm volatile (__ex(ASM_VMX_VMPTRLD_RAX) "; setna %0"
> - : "=g"(error) : "a"(&phys_addr), "m"(phys_addr)
> + : "=qm"(error) : "a"(&phys_addr), "m"(phys_addr)
> : "cc", "memory");
> if (error)
> printk(KERN_ERR "kvm: vmptrld %p/%llx fail\n",
--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
desserts: http://www.xenotime.net/linux/recipes/
next prev parent reply other threads:[~2010-12-20 16:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-20 9:06 [PATCH] KVM: VMX: Correct asm constraint in vmcs_load() Avi Kivity
2010-12-20 16:56 ` Randy Dunlap [this message]
2010-12-20 17:47 ` Avi Kivity
2010-12-20 17:53 ` Randy Dunlap
2010-12-20 17:57 ` Avi Kivity
2010-12-20 17:58 ` Avi Kivity
2010-12-20 18:22 ` Randy Dunlap
2010-12-20 18:26 ` Avi Kivity
2010-12-20 19:16 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D0F8AA2.3010301@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox