From mboxrd@z Thu Jan 1 00:00:00 1970 From: Randy Dunlap Subject: Re: [PATCH] KVM: VMX: Correct asm constraint in vmcs_load() Date: Mon, 20 Dec 2010 08:56:02 -0800 Message-ID: <4D0F8AA2.3010301@oracle.com> References: <1292835996-7274-1-git-send-email-avi@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm@vger.kernel.org To: Avi Kivity Return-path: Received: from rcsinet10.oracle.com ([148.87.113.121]:20674 "EHLO rcsinet10.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932292Ab0LTQ4m (ORCPT ); Mon, 20 Dec 2010 11:56:42 -0500 In-Reply-To: <1292835996-7274-1-git-send-email-avi@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 12/20/10 01:06, Avi Kivity wrote: > 'error' is byte sized, so use a byte register constraint. Hm, OK, but I still get the same build error. > Signed-off-by: Avi Kivity > --- > arch/x86/kvm/vmx.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c > index c195260..a92fdde 100644 > --- a/arch/x86/kvm/vmx.c > +++ b/arch/x86/kvm/vmx.c > @@ -488,7 +488,7 @@ static void vmcs_load(struct vmcs *vmcs) > u8 error; > > asm volatile (__ex(ASM_VMX_VMPTRLD_RAX) "; setna %0" > - : "=g"(error) : "a"(&phys_addr), "m"(phys_addr) > + : "=qm"(error) : "a"(&phys_addr), "m"(phys_addr) > : "cc", "memory"); > if (error) > printk(KERN_ERR "kvm: vmptrld %p/%llx fail\n", -- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** desserts: http://www.xenotime.net/linux/recipes/