Re: [PATCH] KVM: VMX: Correct asm constraint in vmcs_load()

[Randy Dunlap <randy.dunlap@oracle.com>]

On 12/20/10 09:47, Avi Kivity wrote:
> On 12/20/2010 06:56 PM, Randy Dunlap wrote:
>> On 12/20/10 01:06, Avi Kivity wrote:
>> >  'error' is byte sized, so use a byte register constraint.
>>
>> Hm, OK, but I still get the same build error.
> 
> Not okay then.  Can you verify that by removing the content of the
> function the problem goes away?

Nope.  I put #if 0 / #endif around the asm() and if (error) lines
but I still get the error message:

linux-next-20101217/arch/x86/kvm/vmx.c: Assembler messages:
linux-next-20101217/arch/x86/kvm/vmx.c:488: Error: bad register name `%sil'

which is on the "u8 error;" line below:

static void vmcs_load(struct vmcs *vmcs)
{
	u64 phys_addr = __pa(vmcs);
	u8 error;


> What gcc are you using?

> gcc --version
gcc (GCC) 4.4.1 20090725 (Red Hat 4.4.1-2)

-- 
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
desserts:  http://www.xenotime.net/linux/recipes/