From mboxrd@z Thu Jan  1 00:00:00 1970
From: Randy Dunlap <randy.dunlap@oracle.com>
Subject: Re: [PATCH] KVM: VMX: Correct asm constraint in vmcs_load()
Date: Mon, 20 Dec 2010 09:53:26 -0800
Message-ID: <4D0F9816.7050003@oracle.com>
References: <1292835996-7274-1-git-send-email-avi@redhat.com> <4D0F8AA2.3010301@oracle.com> <4D0F96C0.8040101@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: Marcelo Tosatti <mtosatti@redhat.com>, kvm@vger.kernel.org
To: Avi Kivity <avi@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from rcsinet10.oracle.com ([148.87.113.121]:37115 "EHLO
	rcsinet10.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932958Ab0LTRye (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 20 Dec 2010 12:54:34 -0500
In-Reply-To: <4D0F96C0.8040101@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 12/20/10 09:47, Avi Kivity wrote:
> On 12/20/2010 06:56 PM, Randy Dunlap wrote:
>> On 12/20/10 01:06, Avi Kivity wrote:
>> >  'error' is byte sized, so use a byte register constraint.
>>
>> Hm, OK, but I still get the same build error.
> 
> Not okay then.  Can you verify that by removing the content of the
> function the problem goes away?

Nope.  I put #if 0 / #endif around the asm() and if (error) lines
but I still get the error message:

linux-next-20101217/arch/x86/kvm/vmx.c: Assembler messages:
linux-next-20101217/arch/x86/kvm/vmx.c:488: Error: bad register name `%sil'

which is on the "u8 error;" line below:

static void vmcs_load(struct vmcs *vmcs)
{
	u64 phys_addr = __pa(vmcs);
	u8 error;


> What gcc are you using?

> gcc --version
gcc (GCC) 4.4.1 20090725 (Red Hat 4.4.1-2)

-- 
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
desserts:  http://www.xenotime.net/linux/recipes/