From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 5/8] kvm/svm: enhance MOV CR intercept handler Date: Tue, 21 Dec 2010 15:43:20 +0200 Message-ID: <4D10AEF8.4030507@redhat.com> References: <1292926327-19319-1-git-send-email-andre.przywara@amd.com> <1292926327-19319-6-git-send-email-andre.przywara@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: mtosatti@redhat.com, kvm@vger.kernel.org To: Andre Przywara Return-path: Received: from mx1.redhat.com ([209.132.183.28]:33885 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750828Ab0LUNnY (ORCPT ); Tue, 21 Dec 2010 08:43:24 -0500 In-Reply-To: <1292926327-19319-6-git-send-email-andre.przywara@amd.com> Sender: kvm-owner@vger.kernel.org List-ID: On 12/21/2010 12:12 PM, Andre Przywara wrote: > Newer SVM implementations provide the GPR number in the VMCB, so > that the emulation path is no longer necesarry to handle CR > register access intercepts. Implement the handling in svm.c and > use it when the info is provided. > > > +static int cr_interception(struct vcpu_svm *svm) > +{ > ... > + case 3: > + val = svm->vcpu.arch.cr3; > + break; This is a logical conflict with my cr3 cacheing patchset, which turns this into kvm_read_cr3(). Marcelo, whichever you apply first, please be sure to fix up the second. -- error compiling committee.c: too many arguments to function