Re: [PATCH v2] KVM: VMX: Correct asm constraint in vmcs_load()/vmcs_clear()

[Randy Dunlap <randy.dunlap@oracle.com>]

On 12/21/10 06:51, Avi Kivity wrote:
> 'error' is byte sized, so use a byte register constraint.
> 
> Signed-off-by: Avi Kivity <avi@redhat.com>

Acked-by: Randy Dunlap <randy.dunlap@oracle.com>

Thanks.

> ---
>  arch/x86/kvm/vmx.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> index c195260..ce7cfc5 100644
> --- a/arch/x86/kvm/vmx.c
> +++ b/arch/x86/kvm/vmx.c
> @@ -475,7 +475,7 @@ static void vmcs_clear(struct vmcs *vmcs)
>  	u8 error;
>  
>  	asm volatile (__ex(ASM_VMX_VMCLEAR_RAX) "; setna %0"
> -		      : "=g"(error) : "a"(&phys_addr), "m"(phys_addr)
> +		      : "=qm"(error) : "a"(&phys_addr), "m"(phys_addr)
>  		      : "cc", "memory");
>  	if (error)
>  		printk(KERN_ERR "kvm: vmclear fail: %p/%llx\n",
> @@ -488,7 +488,7 @@ static void vmcs_load(struct vmcs *vmcs)
>  	u8 error;
>  
>  	asm volatile (__ex(ASM_VMX_VMPTRLD_RAX) "; setna %0"
> -			: "=g"(error) : "a"(&phys_addr), "m"(phys_addr)
> +			: "=qm"(error) : "a"(&phys_addr), "m"(phys_addr)
>  			: "cc", "memory");
>  	if (error)
>  		printk(KERN_ERR "kvm: vmptrld %p/%llx fail\n",


-- 
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
desserts:  http://www.xenotime.net/linux/recipes/