* [PATCH v2] KVM: VMX: Correct asm constraint in vmcs_load()/vmcs_clear()
@ 2010-12-21 14:51 Avi Kivity
2010-12-21 16:54 ` Randy Dunlap
0 siblings, 1 reply; 2+ messages in thread
From: Avi Kivity @ 2010-12-21 14:51 UTC (permalink / raw)
To: Marcelo Tosatti, kvm; +Cc: Randy Dunlap
'error' is byte sized, so use a byte register constraint.
Signed-off-by: Avi Kivity <avi@redhat.com>
---
arch/x86/kvm/vmx.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
index c195260..ce7cfc5 100644
--- a/arch/x86/kvm/vmx.c
+++ b/arch/x86/kvm/vmx.c
@@ -475,7 +475,7 @@ static void vmcs_clear(struct vmcs *vmcs)
u8 error;
asm volatile (__ex(ASM_VMX_VMCLEAR_RAX) "; setna %0"
- : "=g"(error) : "a"(&phys_addr), "m"(phys_addr)
+ : "=qm"(error) : "a"(&phys_addr), "m"(phys_addr)
: "cc", "memory");
if (error)
printk(KERN_ERR "kvm: vmclear fail: %p/%llx\n",
@@ -488,7 +488,7 @@ static void vmcs_load(struct vmcs *vmcs)
u8 error;
asm volatile (__ex(ASM_VMX_VMPTRLD_RAX) "; setna %0"
- : "=g"(error) : "a"(&phys_addr), "m"(phys_addr)
+ : "=qm"(error) : "a"(&phys_addr), "m"(phys_addr)
: "cc", "memory");
if (error)
printk(KERN_ERR "kvm: vmptrld %p/%llx fail\n",
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] KVM: VMX: Correct asm constraint in vmcs_load()/vmcs_clear()
2010-12-21 14:51 [PATCH v2] KVM: VMX: Correct asm constraint in vmcs_load()/vmcs_clear() Avi Kivity
@ 2010-12-21 16:54 ` Randy Dunlap
0 siblings, 0 replies; 2+ messages in thread
From: Randy Dunlap @ 2010-12-21 16:54 UTC (permalink / raw)
To: Avi Kivity; +Cc: Marcelo Tosatti, kvm
On 12/21/10 06:51, Avi Kivity wrote:
> 'error' is byte sized, so use a byte register constraint.
>
> Signed-off-by: Avi Kivity <avi@redhat.com>
Acked-by: Randy Dunlap <randy.dunlap@oracle.com>
Thanks.
> ---
> arch/x86/kvm/vmx.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> index c195260..ce7cfc5 100644
> --- a/arch/x86/kvm/vmx.c
> +++ b/arch/x86/kvm/vmx.c
> @@ -475,7 +475,7 @@ static void vmcs_clear(struct vmcs *vmcs)
> u8 error;
>
> asm volatile (__ex(ASM_VMX_VMCLEAR_RAX) "; setna %0"
> - : "=g"(error) : "a"(&phys_addr), "m"(phys_addr)
> + : "=qm"(error) : "a"(&phys_addr), "m"(phys_addr)
> : "cc", "memory");
> if (error)
> printk(KERN_ERR "kvm: vmclear fail: %p/%llx\n",
> @@ -488,7 +488,7 @@ static void vmcs_load(struct vmcs *vmcs)
> u8 error;
>
> asm volatile (__ex(ASM_VMX_VMPTRLD_RAX) "; setna %0"
> - : "=g"(error) : "a"(&phys_addr), "m"(phys_addr)
> + : "=qm"(error) : "a"(&phys_addr), "m"(phys_addr)
> : "cc", "memory");
> if (error)
> printk(KERN_ERR "kvm: vmptrld %p/%llx fail\n",
--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
desserts: http://www.xenotime.net/linux/recipes/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-12-21 16:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-21 14:51 [PATCH v2] KVM: VMX: Correct asm constraint in vmcs_load()/vmcs_clear() Avi Kivity
2010-12-21 16:54 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox