From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: [PATCH] kvm: x86: Remove obsolet SS.RPL/DPL aligment Date: Mon, 27 Dec 2010 15:57:35 +0100 Message-ID: <4D18A95F.2010601@web.de> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigF346E4AF91684E4C47809DC4" Cc: kvm , qemu-devel To: Avi Kivity , Marcelo Tosatti Return-path: Received: from fmmailgate03.web.de ([217.72.192.234]:41208 "EHLO fmmailgate03.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753961Ab0L0O7i (ORCPT ); Mon, 27 Dec 2010 09:59:38 -0500 Sender: kvm-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigF346E4AF91684E4C47809DC4 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable From: Jan Kiszka This seems to date back to the days KVM didn't support real mode. The check is no longer needed and, even worse, is corrupting the guest state in case SS.RPL !=3D DPL. Signed-off-by: Jan Kiszka --- target-i386/kvm.c | 7 ------- 1 files changed, 0 insertions(+), 7 deletions(-) diff --git a/target-i386/kvm.c b/target-i386/kvm.c index b3d7c54..85edacc 100644 --- a/target-i386/kvm.c +++ b/target-i386/kvm.c @@ -780,13 +780,6 @@ static int kvm_put_sregs(CPUState *env) set_seg(&sregs.fs, &env->segs[R_FS]); set_seg(&sregs.gs, &env->segs[R_GS]); set_seg(&sregs.ss, &env->segs[R_SS]); - - if (env->cr[0] & CR0_PE_MASK) { - /* force ss cpl to cs cpl */ - sregs.ss.selector =3D (sregs.ss.selector & ~3) | - (sregs.cs.selector & 3); - sregs.ss.dpl =3D sregs.ss.selector & 3; - } } =20 set_seg(&sregs.tr, &env->tr); --=20 1.7.1 --------------enigF346E4AF91684E4C47809DC4 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.15 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org/ iEYEARECAAYFAk0YqV8ACgkQitSsb3rl5xT5BQCfUfNbTM23UL7EbOLMd+rQ/Z5+ DVIAn1YjiqG4848rjjG94doz3M5UGU6B =SJpW -----END PGP SIGNATURE----- --------------enigF346E4AF91684E4C47809DC4--