From: Avi Kivity <avi@redhat.com>
To: Gleb Natapov <gleb@redhat.com>
Cc: mtosatti@redhat.com, kvm@vger.kernel.org
Subject: Re: [PATCH RESEND] KVM: when entering real mode align segment base to 16 bytes
Date: Mon, 27 Dec 2010 17:15:51 +0200 [thread overview]
Message-ID: <4D18ADA7.1080402@redhat.com> (raw)
In-Reply-To: <20101227145842.GO2231@redhat.com>
On 12/27/2010 04:58 PM, Gleb Natapov wrote:
> On Mon, Dec 27, 2010 at 04:55:08PM +0200, Avi Kivity wrote:
> > On 12/27/2010 04:37 PM, Gleb Natapov wrote:
> > >> What's the scenario here? And what segment is involved? if it's fs
> > >> or gs, or maybe ss, I can see it working out, but hardly otherwise.
> > >>
> > >The scenario is older Seabios that lefts DS segment unaligned during
> > >switch to real mode in int1587 function (copy extended memory).
> > >
> >
> > Did it not use %ds then?
> >
> It restores %ds before first use. There can be other guests of course
> that try to use %ds in protected mode. We can distinguish one from the
> other.
Okay. Please add a printk_once() if we lose some bits here, so we know
something bad happened.
In theory we should do this for the other cases too, but they have been
there long enough.
--
error compiling committee.c: too many arguments to function
prev parent reply other threads:[~2010-12-27 15:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-27 13:01 [PATCH RESEND] KVM: when entering real mode align segment base to 16 bytes Gleb Natapov
2010-12-27 14:21 ` Avi Kivity
2010-12-27 14:37 ` Gleb Natapov
2010-12-27 14:55 ` Avi Kivity
2010-12-27 14:58 ` Gleb Natapov
2010-12-27 15:15 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D18ADA7.1080402@redhat.com \
--to=avi@redhat.com \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox