* [PATCH] Add ability to drop pages through testdev
@ 2010-12-22 15:18 Gleb Natapov
2010-12-29 9:50 ` Avi Kivity
0 siblings, 1 reply; 6+ messages in thread
From: Gleb Natapov @ 2010-12-22 15:18 UTC (permalink / raw)
To: avi, mtosatti; +Cc: kvm
Signed-off-by: Gleb Natapov <gleb@redhat.com>
diff --git a/hw/testdev.c b/hw/testdev.c
index d1abf59..29df385 100644
--- a/hw/testdev.c
+++ b/hw/testdev.c
@@ -1,3 +1,4 @@
+#include <sys/mman.h>
#include "hw.h"
#include "qdev.h"
#include "isa.h"
@@ -46,6 +47,16 @@ static uint32_t test_device_ioport_read(void *opaque, uint32_t addr)
return test_device_ioport_data;
}
+static void test_device_flush_page(void *opaque, uint32_t addr, uint32_t data)
+{
+ target_phys_addr_t len = 4096;
+ void *a = cpu_physical_memory_map(data & ~0xffful, &len, 0);
+
+ mprotect(a, 4096, PROT_NONE);
+ mprotect(a, 4096, PROT_READ|PROT_WRITE);
+ cpu_physical_memory_unmap(a, len, 0, 0);
+}
+
static char *iomem_buf;
static uint32_t test_iomem_readb(void *opaque, target_phys_addr_t addr)
@@ -104,6 +115,7 @@ static int init_test_device(ISADevice *isa)
register_ioport_write(0xe0, 1, 2, test_device_ioport_write, dev);
register_ioport_read(0xe0, 1, 4, test_device_ioport_read, dev);
register_ioport_write(0xe0, 1, 4, test_device_ioport_write, dev);
+ register_ioport_write(0xe4, 1, 4, test_device_flush_page, dev);
register_ioport_write(0x2000, 24, 1, test_device_irq_line, NULL);
iomem_buf = qemu_mallocz(0x10000);
iomem = cpu_register_io_memory(test_iomem_read, test_iomem_write, NULL);
--
Gleb.
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] Add ability to drop pages through testdev
2010-12-22 15:18 [PATCH] Add ability to drop pages through testdev Gleb Natapov
@ 2010-12-29 9:50 ` Avi Kivity
2010-12-29 9:55 ` Gleb Natapov
0 siblings, 1 reply; 6+ messages in thread
From: Avi Kivity @ 2010-12-29 9:50 UTC (permalink / raw)
To: Gleb Natapov; +Cc: mtosatti, kvm
On 12/22/2010 05:18 PM, Gleb Natapov wrote:
> Signed-off-by: Gleb Natapov<gleb@redhat.com>
> diff --git a/hw/testdev.c b/hw/testdev.c
> index d1abf59..29df385 100644
> --- a/hw/testdev.c
> +++ b/hw/testdev.c
> @@ -1,3 +1,4 @@
> +#include<sys/mman.h>
> #include "hw.h"
> #include "qdev.h"
> #include "isa.h"
> @@ -46,6 +47,16 @@ static uint32_t test_device_ioport_read(void *opaque, uint32_t addr)
> return test_device_ioport_data;
> }
>
> +static void test_device_flush_page(void *opaque, uint32_t addr, uint32_t data)
> +{
> + target_phys_addr_t len = 4096;
> + void *a = cpu_physical_memory_map(data& ~0xffful,&len, 0);
> +
> + mprotect(a, 4096, PROT_NONE);
> + mprotect(a, 4096, PROT_READ|PROT_WRITE);
> + cpu_physical_memory_unmap(a, len, 0, 0);
> +}
> +
Icky. This is much better done through the api tests. Applied it so as
not to spoil all the effort.
--
error compiling committee.c: too many arguments to function
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] Add ability to drop pages through testdev
2010-12-29 9:50 ` Avi Kivity
@ 2010-12-29 9:55 ` Gleb Natapov
2010-12-29 9:58 ` Avi Kivity
0 siblings, 1 reply; 6+ messages in thread
From: Gleb Natapov @ 2010-12-29 9:55 UTC (permalink / raw)
To: Avi Kivity; +Cc: mtosatti, kvm
On Wed, Dec 29, 2010 at 11:50:48AM +0200, Avi Kivity wrote:
> On 12/22/2010 05:18 PM, Gleb Natapov wrote:
> >Signed-off-by: Gleb Natapov<gleb@redhat.com>
> >diff --git a/hw/testdev.c b/hw/testdev.c
> >index d1abf59..29df385 100644
> >--- a/hw/testdev.c
> >+++ b/hw/testdev.c
> >@@ -1,3 +1,4 @@
> >+#include<sys/mman.h>
> > #include "hw.h"
> > #include "qdev.h"
> > #include "isa.h"
> >@@ -46,6 +47,16 @@ static uint32_t test_device_ioport_read(void *opaque, uint32_t addr)
> > return test_device_ioport_data;
> > }
> >
> >+static void test_device_flush_page(void *opaque, uint32_t addr, uint32_t data)
> >+{
> >+ target_phys_addr_t len = 4096;
> >+ void *a = cpu_physical_memory_map(data& ~0xffful,&len, 0);
> >+
> >+ mprotect(a, 4096, PROT_NONE);
> >+ mprotect(a, 4096, PROT_READ|PROT_WRITE);
> >+ cpu_physical_memory_unmap(a, len, 0, 0);
> >+}
> >+
>
> Icky. This is much better done through the api tests. Applied it
> so as not to spoil all the effort.
>
How would you do that there?
--
Gleb.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] Add ability to drop pages through testdev
2010-12-29 9:55 ` Gleb Natapov
@ 2010-12-29 9:58 ` Avi Kivity
2010-12-29 10:03 ` Gleb Natapov
0 siblings, 1 reply; 6+ messages in thread
From: Avi Kivity @ 2010-12-29 9:58 UTC (permalink / raw)
To: Gleb Natapov; +Cc: mtosatti, kvm
On 12/29/2010 11:55 AM, Gleb Natapov wrote:
> On Wed, Dec 29, 2010 at 11:50:48AM +0200, Avi Kivity wrote:
> > On 12/22/2010 05:18 PM, Gleb Natapov wrote:
> > >Signed-off-by: Gleb Natapov<gleb@redhat.com>
> > >diff --git a/hw/testdev.c b/hw/testdev.c
> > >index d1abf59..29df385 100644
> > >--- a/hw/testdev.c
> > >+++ b/hw/testdev.c
> > >@@ -1,3 +1,4 @@
> > >+#include<sys/mman.h>
> > > #include "hw.h"
> > > #include "qdev.h"
> > > #include "isa.h"
> > >@@ -46,6 +47,16 @@ static uint32_t test_device_ioport_read(void *opaque, uint32_t addr)
> > > return test_device_ioport_data;
> > > }
> > >
> > >+static void test_device_flush_page(void *opaque, uint32_t addr, uint32_t data)
> > >+{
> > >+ target_phys_addr_t len = 4096;
> > >+ void *a = cpu_physical_memory_map(data& ~0xffful,&len, 0);
> > >+
> > >+ mprotect(a, 4096, PROT_NONE);
> > >+ mprotect(a, 4096, PROT_READ|PROT_WRITE);
> > >+ cpu_physical_memory_unmap(a, len, 0, 0);
> > >+}
> > >+
> >
> > Icky. This is much better done through the api tests. Applied it
> > so as not to spoil all the effort.
> >
> How would you do that there?
Set up all the state using the KVM_SET_REGS family, pointing to the
instruction you want to test, and KVM_RUN that. You can even queue
exceptions and interrupts for complicated cases.
--
error compiling committee.c: too many arguments to function
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] Add ability to drop pages through testdev
2010-12-29 9:58 ` Avi Kivity
@ 2010-12-29 10:03 ` Gleb Natapov
2010-12-29 10:05 ` Avi Kivity
0 siblings, 1 reply; 6+ messages in thread
From: Gleb Natapov @ 2010-12-29 10:03 UTC (permalink / raw)
To: Avi Kivity; +Cc: mtosatti, kvm
On Wed, Dec 29, 2010 at 11:58:31AM +0200, Avi Kivity wrote:
> On 12/29/2010 11:55 AM, Gleb Natapov wrote:
> >On Wed, Dec 29, 2010 at 11:50:48AM +0200, Avi Kivity wrote:
> >> On 12/22/2010 05:18 PM, Gleb Natapov wrote:
> >> >Signed-off-by: Gleb Natapov<gleb@redhat.com>
> >> >diff --git a/hw/testdev.c b/hw/testdev.c
> >> >index d1abf59..29df385 100644
> >> >--- a/hw/testdev.c
> >> >+++ b/hw/testdev.c
> >> >@@ -1,3 +1,4 @@
> >> >+#include<sys/mman.h>
> >> > #include "hw.h"
> >> > #include "qdev.h"
> >> > #include "isa.h"
> >> >@@ -46,6 +47,16 @@ static uint32_t test_device_ioport_read(void *opaque, uint32_t addr)
> >> > return test_device_ioport_data;
> >> > }
> >> >
> >> >+static void test_device_flush_page(void *opaque, uint32_t addr, uint32_t data)
> >> >+{
> >> >+ target_phys_addr_t len = 4096;
> >> >+ void *a = cpu_physical_memory_map(data& ~0xffful,&len, 0);
> >> >+
> >> >+ mprotect(a, 4096, PROT_NONE);
> >> >+ mprotect(a, 4096, PROT_READ|PROT_WRITE);
> >> >+ cpu_physical_memory_unmap(a, len, 0, 0);
> >> >+}
> >> >+
> >>
> >> Icky. This is much better done through the api tests. Applied it
> >> so as not to spoil all the effort.
> >>
> >How would you do that there?
>
> Set up all the state using the KVM_SET_REGS family, pointing to the
> instruction you want to test, and KVM_RUN that. You can even queue
> exceptions and interrupts for complicated cases.
>
I mean how do you drop a page from shadow/ept tables? Wouldn't you have
to do the same trick there?
--
Gleb.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] Add ability to drop pages through testdev
2010-12-29 10:03 ` Gleb Natapov
@ 2010-12-29 10:05 ` Avi Kivity
0 siblings, 0 replies; 6+ messages in thread
From: Avi Kivity @ 2010-12-29 10:05 UTC (permalink / raw)
To: Gleb Natapov; +Cc: mtosatti, kvm
On 12/29/2010 12:03 PM, Gleb Natapov wrote:
> > >> Icky. This is much better done through the api tests. Applied it
> > >> so as not to spoil all the effort.
> > >>
> > >How would you do that there?
> >
> > Set up all the state using the KVM_SET_REGS family, pointing to the
> > instruction you want to test, and KVM_RUN that. You can even queue
> > exceptions and interrupts for complicated cases.
> >
> I mean how do you drop a page from shadow/ept tables? Wouldn't you have
> to do the same trick there?
>
Yes, but you just call munmap(), you don't have to go through testdev.
--
error compiling committee.c: too many arguments to function
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-12-29 10:05 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-22 15:18 [PATCH] Add ability to drop pages through testdev Gleb Natapov
2010-12-29 9:50 ` Avi Kivity
2010-12-29 9:55 ` Gleb Natapov
2010-12-29 9:58 ` Avi Kivity
2010-12-29 10:03 ` Gleb Natapov
2010-12-29 10:05 ` Avi Kivity
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox