From: Avi Kivity <avi@redhat.com>
To: Sheng Yang <sheng@linux.intel.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>, kvm@vger.kernel.org
Subject: Re: [PATCH] KVM: VMX: Fix 32bit Windows blue screen with EPT
Date: Thu, 30 Dec 2010 11:14:23 +0200 [thread overview]
Message-ID: <4D1C4D6F.7030707@redhat.com> (raw)
In-Reply-To: <201012301705.28771.sheng@linux.intel.com>
On 12/30/2010 11:05 AM, Sheng Yang wrote:
> >
> > > if (!(cr0& X86_CR0_PG)) {
> > >
> > > /* From paging/starting to nonpaging */
> > > vmcs_write32(CPU_BASED_VM_EXEC_CONTROL,
> > >
> > > @@ -1937,11 +1936,8 @@ static void ept_update_paging_mode_cr0(unsigned
> > > long *hw_cr0,
> > >
> > > vmcs_read32(CPU_BASED_VM_EXEC_CONTROL)&
> > >
> > > ~(CPU_BASED_CR3_LOAD_EXITING |
> > >
> > > CPU_BASED_CR3_STORE_EXITING));
> > >
> > > - /* Must fetch cr3 before updating cr0 */
> > > - cr3 = kvm_read_cr3(vcpu);
> > >
> > > vcpu->arch.cr0 = cr0;
> > > vmx_set_cr4(vcpu, kvm_read_cr4(vcpu));
> > >
> > > - vmx_set_cr3(vcpu, cr3);
> >
> > This is indeed bogus. But what ensures that we'll have the correct
> > GUEST_CR3 after enabling paging?
>
> In fact I don't understand why we need this line. All modification is for CR3
> reading, why we need to set hardware CR3 again? It should be the same as when we
> don't have CR3 accessor I think.
when cr0.pg=0 then we set GUEST_CR3=identity_pagetable. We don't want
that when we we switch to paging mode.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2010-12-30 9:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-30 8:35 [PATCH] KVM: VMX: Fix 32bit Windows blue screen with EPT Sheng Yang
2010-12-30 8:57 ` Avi Kivity
2010-12-30 9:05 ` Sheng Yang
2010-12-30 9:14 ` Avi Kivity [this message]
2010-12-30 9:20 ` Sheng Yang
2010-12-30 9:23 ` Avi Kivity
2010-12-30 9:09 ` Sheng Yang
2010-12-30 9:16 ` Avi Kivity
2010-12-30 9:21 ` [PATCH v2] " Sheng Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D1C4D6F.7030707@redhat.com \
--to=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=sheng@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox