From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 2/2][RFC] KVM: Emulate MSI-X table and PBA in kernel Date: Thu, 30 Dec 2010 11:28:20 +0200 Message-ID: <4D1C50B4.4020907@redhat.com> References: <1293007495-32325-1-git-send-email-sheng@linux.intel.com> <201012291655.19535.sheng@linux.intel.com> <20101229092824.GA2876@redhat.com> <201012301532.42341.sheng@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: "Michael S. Tsirkin" , Marcelo Tosatti , kvm@vger.kernel.org, Alex Williamson To: Sheng Yang Return-path: Received: from mx1.redhat.com ([209.132.183.28]:1025 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750914Ab0L3J2u (ORCPT ); Thu, 30 Dec 2010 04:28:50 -0500 In-Reply-To: <201012301532.42341.sheng@linux.intel.com> Sender: kvm-owner@vger.kernel.org List-ID: On 12/30/2010 09:32 AM, Sheng Yang wrote: > > > > I don't think it's going to work: we are not > > in the context of the right process. Further > > I think we should keep the option of > > reading the PBA status from the device or host kernel open. > > And generally having an interface > > for functionality we don't implement is not a good idea: > > you don't know whether you really can support the interface you promised. > > Well, I don't know if we want to read PBA from device directly. To me it's not a > good idea because the real device has nothing to do with the one we show to the > guest. Right. vPBA.bit = pPBA.bit | recorded_pending_bit_from_lazy_masked_interrupt. > At least direct accessing the mask bits of real device would be very > dangerous. Avi? Agree. -- error compiling committee.c: too many arguments to function