public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@web.de>
To: Avi Kivity <avi@redhat.com>
Cc: kvm <kvm@vger.kernel.org>, qemu-devel <qemu-devel@nongnu.org>
Subject: Re: qemu vs. kvm: When to flush the coalesced mmio buffer?
Date: Mon, 03 Jan 2011 13:34:12 +0100	[thread overview]
Message-ID: <4D21C244.10901@web.de> (raw)
In-Reply-To: <4D21C1D0.6060301@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 686 bytes --]

Am 03.01.2011 13:32, Avi Kivity wrote:
> On 01/03/2011 02:11 PM, Jan Kiszka wrote:
>> Hi again,
>>
>> another subtle difference between qemu-kvm and upstream:
>>
>> When we leave the guest for an IO window (KVM_RUN returns EINTR or
>> EAGAIN), we call kvm_flush_coalesced_mmio_buffer in qemu-kvm but not in
>> upstream. When version is better? I can't find any rationales in both
>> git logs.
> 
> We must flush on EINTR, otherwise a live migration can leave some mmios
> in the source host and not replay them on the destination host.
> 
> (plus, as Gleb says, if you're in userspace you might as well flush)
> 

OK, will append a fix to my series.

Thanks,
Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]

      reply	other threads:[~2011-01-03 12:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-03 12:11 qemu vs. kvm: When to flush the coalesced mmio buffer? Jan Kiszka
2011-01-03 12:25 ` [Qemu-devel] " Gleb Natapov
2011-01-03 12:32 ` Avi Kivity
2011-01-03 12:34   ` Jan Kiszka [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D21C244.10901@web.de \
    --to=jan.kiszka@web.de \
    --cc=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox