From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: qemu vs. kvm: When to flush the coalesced mmio buffer? Date: Mon, 03 Jan 2011 13:34:12 +0100 Message-ID: <4D21C244.10901@web.de> References: <4D21BCF4.6020904@web.de> <4D21C1D0.6060301@redhat.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig3B4580024ED65C08E7EEA3D1" Cc: kvm , qemu-devel To: Avi Kivity Return-path: Received: from fmmailgate02.web.de ([217.72.192.227]:47792 "EHLO fmmailgate02.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754341Ab1ACMeO (ORCPT ); Mon, 3 Jan 2011 07:34:14 -0500 In-Reply-To: <4D21C1D0.6060301@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig3B4580024ED65C08E7EEA3D1 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Am 03.01.2011 13:32, Avi Kivity wrote: > On 01/03/2011 02:11 PM, Jan Kiszka wrote: >> Hi again, >> >> another subtle difference between qemu-kvm and upstream: >> >> When we leave the guest for an IO window (KVM_RUN returns EINTR or >> EAGAIN), we call kvm_flush_coalesced_mmio_buffer in qemu-kvm but not i= n >> upstream. When version is better? I can't find any rationales in both >> git logs. >=20 > We must flush on EINTR, otherwise a live migration can leave some mmios= > in the source host and not replay them on the destination host. >=20 > (plus, as Gleb says, if you're in userspace you might as well flush) >=20 OK, will append a fix to my series. Thanks, Jan --------------enig3B4580024ED65C08E7EEA3D1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.15 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org/ iEYEARECAAYFAk0hwkQACgkQitSsb3rl5xQOtgCgrpUzMPkT9ICuXP8zKK1OX1xs F/sAn2JvzlWRyjwdZJ5EnZ0PD1a2O169 =VuJK -----END PGP SIGNATURE----- --------------enig3B4580024ED65C08E7EEA3D1--