From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH v2 14/17] kvm: x86: Introduce kvmclock device to save/restore its state Date: Mon, 03 Jan 2011 18:04:53 +0200 Message-ID: <4D21F3A5.1030905@redhat.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm@vger.kernel.org, qemu-devel@nongnu.org, Jan Kiszka , Glauber Costa To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:24899 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932110Ab1ACQFB (ORCPT ); Mon, 3 Jan 2011 11:05:01 -0500 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On 01/03/2011 10:33 AM, Jan Kiszka wrote: > From: Jan Kiszka > > If kvmclock is used, which implies the kernel supports it, register a > kvmclock device with the sysbus. Its main purpose is to save and restore > the kernel state on migration, but this will also allow to visualize it > one day. > kvmclock is a per-cpu affair. > > @@ -534,6 +599,10 @@ int kvm_arch_init(int smp_cpus) > int ret; > struct utsname utsname; > > +#ifdef KVM_CAP_ADJUST_CLOCK > + sysbus_register_withprop(&kvmclock_info); > +#endif > + So this doesn't look right. I think we're fine with just migrating the MSRs, like we migrate anything else that has to do with the cpu. -- error compiling committee.c: too many arguments to function