From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH v2 17/17] kvm: Drop dependencies on very old capabilities Date: Mon, 03 Jan 2011 18:08:04 +0200 Message-ID: <4D21F464.1070807@redhat.com> References: <4ffa4f23bc93aa5af90d836986771bb6d9856bf9.1294043582.git.jan.kiszka@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm@vger.kernel.org, qemu-devel@nongnu.org, Jan Kiszka To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:57896 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932146Ab1ACQIP (ORCPT ); Mon, 3 Jan 2011 11:08:15 -0500 In-Reply-To: <4ffa4f23bc93aa5af90d836986771bb6d9856bf9.1294043582.git.jan.kiszka@web.de> Sender: kvm-owner@vger.kernel.org List-ID: On 01/03/2011 10:33 AM, Jan Kiszka wrote: > From: Jan Kiszka > > COALESCED_MMIO, SYNC_MMU, EXT_CPUID, CLOCKSOURCE, NOP_IO_DELAY, PV_MMU - > all these caps predate features on which we already depend at build > time. Moreover, the check for KVM_CAP_EXT_CPUID is unneeded as we > already test& fail is a more recent feature is missing. No. Each test documents a dependency of qemu on a kvm feature. Even though something like SYNC_MMU is unlikely to go away, as long as we depend on it, we require the feature. -- error compiling committee.c: too many arguments to function