Re: [PATCH v2 00/17] [uq/master] Prepare for more qemu-kvm merging

Avi Kivity
2011-01-03T16:09:37Z

On 01/03/2011 10:32 AM, Jan Kiszka wrote:
> All previously sent patches against current uq combined, some smaller
> tweaks applied, and 4 new patches added. Major news is support for
> using up to 16M BIOSes and optional code dump for cpu_dump_state. Those
> features are already present qemu-kvm but were reworked to provide
> cleaner upstream versions.
>

Looks reasonable overall.

> Based on this series, I've an experimental tree here where I eliminated
> another 1500 LOC from qemu-kvm code. Specifically, that tree sets an end
> to duplicate KVM and VCPU initialization functions, KVMState copies, and
> redundant state saving/loading functions. Will be rolled out after some
> more review and testing.

Sounds really frightening... this glue code is a real breeding ground
for subtle bugs and merge problems.

--
error compiling committee.c: too many arguments to function