From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH v2 14/17] kvm: x86: Introduce kvmclock device to save/restore its state Date: Mon, 03 Jan 2011 17:48:11 +0100 Message-ID: <4D21FDCB.70504@web.de> References: <1294072661.5370.22.camel@mothafucka.localdomain> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig8A17030AE9E37C3C72165D58" Cc: Avi Kivity , Marcelo Tosatti , kvm@vger.kernel.org, qemu-devel@nongnu.org, Jan Kiszka To: Glauber Costa Return-path: Received: from fmmailgate02.web.de ([217.72.192.227]:55985 "EHLO fmmailgate02.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932323Ab1ACQsi (ORCPT ); Mon, 3 Jan 2011 11:48:38 -0500 In-Reply-To: <1294072661.5370.22.camel@mothafucka.localdomain> Sender: kvm-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig8A17030AE9E37C3C72165D58 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Am 03.01.2011 17:37, Glauber Costa wrote: > On Mon, 2011-01-03 at 09:33 +0100, Jan Kiszka wrote: >> From: Jan Kiszka >> >> If kvmclock is used, which implies the kernel supports it, register a >> kvmclock device with the sysbus. Its main purpose is to save and resto= re >> the kernel state on migration, but this will also allow to visualize i= t >> one day. >> >> Signed-off-by: Jan Kiszka >> CC: Glauber Costa >=20 > Hi Jan. >=20 > I've just recently posted a patch (not sure what was made from it), tha= t > fixes a bug that you reintroduce here. Hmm, must have missed it. >=20 > The bug is: if we call KVM_GET_CLOCK ioctl in pre_save, this means that= > this value will change every time we issue savevm, even if the machine > is not run in between. >=20 > Ideally, we'd like to have two consecutive savevms returning the exact > same thing in that situation. >=20 > I like the general approach of moving it to sysbus, but please move the= > ioctl to change state notifiers. OK, will look into this. Jan --------------enig8A17030AE9E37C3C72165D58 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.15 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org/ iEYEARECAAYFAk0h/csACgkQitSsb3rl5xQtPwCfdB5+tRxbFAlYdTkWjTRLDckU I50AoNCuCdCFaWNKUKnpy6gSRPlk6Vc8 =oguc -----END PGP SIGNATURE----- --------------enig8A17030AE9E37C3C72165D58--