Re: [PATCH v2 17/17] kvm: Drop dependencies on very old capabilities

Jan Kiszka
2011-01-03T16:54:34Z

[-- Attachment #1: Type: text/plain, Size: 924 bytes --]

Am 03.01.2011 17:08, Avi Kivity wrote:
> On 01/03/2011 10:33 AM, Jan Kiszka wrote:
>> From: Jan Kiszka<jan.kiszka@siemens.com>
>>
>> COALESCED_MMIO, SYNC_MMU, EXT_CPUID, CLOCKSOURCE, NOP_IO_DELAY, PV_MMU -
>> all these caps predate features on which we already depend at build
>> time. Moreover, the check for KVM_CAP_EXT_CPUID is unneeded as we
>> already test& fail is a more recent feature is missing.
>
> No. Each test documents a dependency of qemu on a kvm feature. Even
> though something like SYNC_MMU is unlikely to go away, as long as we
> depend on it, we require the feature.
>

Then at least move all those KVM_CAPs we need at build time into
configure. I really see no value in keeping ugly conditional code
around, A) because those paths won't be tested and B) none of the CAPs
touched here are to pass away without a replacement that will require
user space adaption anyway.

Jan

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]