From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH v2 00/17] [uq/master] Prepare for more qemu-kvm merging Date: Tue, 04 Jan 2011 11:02:23 +0200 Message-ID: <4D22E21F.1040908@redhat.com> References: <4D21F4BD.8040708@redhat.com> <4D22DD5D.6090106@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm@vger.kernel.org, qemu-devel@nongnu.org To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:1388 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750824Ab1ADJDI (ORCPT ); Tue, 4 Jan 2011 04:03:08 -0500 In-Reply-To: <4D22DD5D.6090106@web.de> Sender: kvm-owner@vger.kernel.org List-ID: On 01/04/2011 10:42 AM, Jan Kiszka wrote: > > > > Sounds really frightening... this glue code is a real breeding ground > > for subtle bugs and merge problems. > > ...and that's why we are more than late with unifying it into a single > code base. > > After that upcoming cleanup round we will have three major remaining to-dos: > - in-kernel irqchip and PIT support with the subtopics > - VAPIC/TPR-patching support > - IRQ routing > - PCI device assignment > - VCPU& IO-thread execution model > > While I'm not that concerned about the first two as they basically add > code that "just" needs to be refactored, the last one is worrying me. We > need to find a smart way to morph one into the other. The code is full > of subtle differences and is likely quite performance sensitive. Agreed on all counts. -- error compiling committee.c: too many arguments to function