From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH v3 15/21] kvm: x86: Introduce kvmclock device to save/restore its state Date: Tue, 04 Jan 2011 12:34:17 +0100 Message-ID: <4D2305B9.4010706@web.de> References: <1294139314.5370.34.camel@mothafucka.localdomain> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig42E64917BDC6EB60F2ECF998" Cc: Avi Kivity , Marcelo Tosatti , kvm@vger.kernel.org, qemu-devel@nongnu.org To: Glauber Costa Return-path: Received: from fmmailgate03.web.de ([217.72.192.234]:49958 "EHLO fmmailgate03.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750825Ab1ADLeV (ORCPT ); Tue, 4 Jan 2011 06:34:21 -0500 In-Reply-To: <1294139314.5370.34.camel@mothafucka.localdomain> Sender: kvm-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig42E64917BDC6EB60F2ECF998 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Am 04.01.2011 12:08, Glauber Costa wrote: > On Tue, 2011-01-04 at 09:32 +0100, Jan Kiszka wrote: >> From: Jan Kiszka >> >> If kvmclock is used, which implies the kernel supports it, register a >> kvmclock device with the sysbus. Its main purpose is to save and resto= re >> the kernel state on migration, but this will also allow to visualize i= t >> one day. >=20 > I would prefer having no pre-save, and doing the ioctl in the state > change handler. But I won't nitpick about that, if the maintainers thin= k > this is okay, all the rest of the patch looks fine as well. I did this for a reason: to be able to obtain the current clock state even while the vm is running. It's cleaner IMHO. Jan --------------enig42E64917BDC6EB60F2ECF998 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.15 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org/ iEYEARECAAYFAk0jBboACgkQitSsb3rl5xTkAACgpXICrzGqEb9YU9QrnctcBdav oWkAn0TzI/CHAcpu227A5YmNS40DDdg9 =Xgrw -----END PGP SIGNATURE----- --------------enig42E64917BDC6EB60F2ECF998--