From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH v3 15/21] kvm: x86: Introduce kvmclock device to save/restore its state Date: Tue, 04 Jan 2011 12:45:05 +0100 Message-ID: <4D230841.1070706@web.de> References: <1294139314.5370.34.camel@mothafucka.localdomain> <4D2305B9.4010706@web.de> <1294141387.5370.35.camel@mothafucka.localdomain> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig08F542930AB720489124C748" Cc: Avi Kivity , Marcelo Tosatti , kvm@vger.kernel.org, qemu-devel@nongnu.org To: Glauber Costa Return-path: Received: from fmmailgate03.web.de ([217.72.192.234]:33484 "EHLO fmmailgate03.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751016Ab1ADLpH (ORCPT ); Tue, 4 Jan 2011 06:45:07 -0500 In-Reply-To: <1294141387.5370.35.camel@mothafucka.localdomain> Sender: kvm-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig08F542930AB720489124C748 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Am 04.01.2011 12:43, Glauber Costa wrote: > On Tue, 2011-01-04 at 12:34 +0100, Jan Kiszka wrote: >> Am 04.01.2011 12:08, Glauber Costa wrote: >>> On Tue, 2011-01-04 at 09:32 +0100, Jan Kiszka wrote: >>>> From: Jan Kiszka >>>> >>>> If kvmclock is used, which implies the kernel supports it, register = a >>>> kvmclock device with the sysbus. Its main purpose is to save and res= tore >>>> the kernel state on migration, but this will also allow to visualize= it >>>> one day. >>> >>> I would prefer having no pre-save, and doing the ioctl in the state >>> change handler. But I won't nitpick about that, if the maintainers th= ink >>> this is okay, all the rest of the patch looks fine as well. >> >> I did this for a reason: to be able to obtain the current clock state >> even while the vm is running. It's cleaner IMHO. >=20 > but if we're on pre-save, we are certain that the vm is stopped at this= > moment, no ? Maybe at the moment, but not for device state dumping or maybe (dunno) for Kemari's continuous sync'ing. I simply want to avoid this implicit dependency. Jan --------------enig08F542930AB720489124C748 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.15 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org/ iEYEARECAAYFAk0jCEEACgkQitSsb3rl5xQGfACeIymw8mIKmMplMn5Lq3/Bi172 xdQAn3JGhSlYiLevMFI9qSZmCTKfMvjy =vMNq -----END PGP SIGNATURE----- --------------enig08F542930AB720489124C748--