From: Avi Kivity <avi@redhat.com>
To: Rik van Riel <riel@redhat.com>
Cc: "Zhai, Edwin" <edwin.zhai@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"mtosatti@redhat.com" <mtosatti@redhat.com>
Subject: Re: [PATCH] increase ple_gap default to 64
Date: Tue, 04 Jan 2011 16:29:05 +0200 [thread overview]
Message-ID: <4D232EB1.1000304@redhat.com> (raw)
In-Reply-To: <4D232C20.80306@redhat.com>
On 01/04/2011 04:18 PM, Rik van Riel wrote:
> On 01/03/2011 10:21 PM, Zhai, Edwin wrote:
>> Riel,
>> Thanks for your patch. I have changed the ple_gap to 128 on xen side,
>> but forget the patch for KVM:(
>>
>> A little bit big is no harm, but more perf data is better.
>
> So should I resend the patch with the ple_gap default
> changed to 128, or are you willing to ack the current
> patch?
>
I think 128 is safer given than 41 was too low. We have to take into
account newer cpus and slower spin loops. If the spin loop does a cache
ping-pong (which would be a bad, bad possible, implementation), even 128
might be too low.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2011-01-04 14:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-03 15:19 [PATCH] increase ple_gap default to 64 Rik van Riel
2011-01-04 3:21 ` Zhai, Edwin
2011-01-04 14:18 ` Rik van Riel
2011-01-04 14:29 ` Avi Kivity [this message]
2011-01-04 14:35 ` Zhai, Edwin
2011-01-04 14:51 ` [PATCH -v2] vmx: " Rik van Riel
2011-01-14 3:08 ` Zhai, Edwin
2011-01-16 15:42 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D232EB1.1000304@redhat.com \
--to=avi@redhat.com \
--cc=edwin.zhai@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox