From: Avi Kivity <avi@redhat.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: kvm@vger.kernel.org, chrisw@redhat.com
Subject: Re: [PATCH v2] device-assignment: chmod the rom file before opening read/write
Date: Wed, 05 Jan 2011 10:57:49 +0200 [thread overview]
Message-ID: <4D24328D.8050104@redhat.com> (raw)
In-Reply-To: <20110104184516.28545.73442.stgit@s20.home>
On 01/04/2011 08:45 PM, Alex Williamson wrote:
> The PCI sysfs rom file is exposed read-only by default, but we need
> to write to it to enable and disable the ROM around the read. When
> running as root, the code works fine as is, but when running
> de-privileged via libvirt, the fopen("r+") will fail if the file
> doesn't have owner write permissions. libvirt already gives us
> ownership of the file, so we can toggle this around the short
> usage window ourselves.
Why is qemu in the business of chmod()ing resources? If qemu needs
write access to some resource, the user needs to provide that access.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2011-01-05 8:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-04 18:07 [PATCH] device-assignment: chmod the rom file before opening read/write Alex Williamson
2011-01-04 18:30 ` Chris Wright
2011-01-04 18:36 ` Alex Williamson
2011-01-04 18:45 ` [PATCH v2] " Alex Williamson
2011-01-05 8:57 ` Avi Kivity [this message]
2011-01-05 14:57 ` Alex Williamson
2011-01-05 15:14 ` Avi Kivity
2011-01-05 15:26 ` Daniel P. Berrange
2011-01-05 16:28 ` Alex Williamson
2011-01-05 16:23 ` Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D24328D.8050104@redhat.com \
--to=avi@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=chrisw@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox