Re: [RFC -v3 PATCH 2/3] sched: add yield_to function

Tejun Heo
2011-01-06T03:49:40Z

Hello,

On Wed, Jan 05, 2011 at 06:39:19PM +0100, Peter Zijlstra wrote:
> On Wed, 2011-01-05 at 19:35 +0200, Avi Kivity wrote:
>
> > Tejun, why did you end up not using preempt_notifiers in cmwq?
>
> Because I told him to use explicit function calls because that keeps the
> code easier to read.

It went like the following.

* Beefing up preempt_notifier() results in too many different
notifiers. They better be unified.

* Unified notifiers are ugly (macro bonanza as expected) and cmwq
hooks are always enabled unlike other notifiers. Let's just keep it
simple and specialized.

So, the cmwq stuff is now mostly hard coded into scheduler. For cmwq,
everything is fine but it would still be great if the various
notifiers can be assimilated in prettier way.

Thanks.

--
tejun