Re: [RFC -v3 PATCH 2/3] sched: add yield_to function

Avi Kivity
2011-01-05T17:19:49Z

On 01/05/2011 07:15 PM, Peter Zijlstra wrote:
> On Wed, 2011-01-05 at 19:10 +0200, Avi Kivity wrote:
> > On 01/04/2011 08:04 PM, Peter Zijlstra wrote:
> > > This definitely wants to be EXPORT_SYMBOL_GPL() and if it were possible
> > > I'd make it so only kvm.o could use it. It really sucks that kvm is a
> > > module.
> >
> > Why does it suck? I mean apart from the "virtualization is crap" song.
>
> Because it needs hooks all over the core kernel, like this yield_to()
> stuff. Exporting this might lead to others wanting to use it too.

Well, it's very convenient for development (modprobe vs. reboot). What
hooks do you object to? mmu notifiers are useful for some drivers, sched
notifiers are useful for cmwq and possibly perf?

--
error compiling committee.c: too many arguments to function