From: Avi Kivity <avi@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: Michael Goldish <mgoldish@redhat.com>,
autotest@test.kernel.org, kvm@vger.kernel.org
Subject: Re: [KVM-AUTOTEST PATCH v2 3/6] [RFC] Introduce exception context strings
Date: Wed, 05 Jan 2011 18:39:35 +0200 [thread overview]
Message-ID: <4D249EC7.2070204@redhat.com> (raw)
In-Reply-To: <20110105163643.GF3361@otherpad.lan.raisama.net>
On 01/05/2011 06:36 PM, Eduardo Habkost wrote:
> On Wed, Jan 05, 2011 at 06:21:35PM +0200, Avi Kivity wrote:
> > btw, you can have a decorator for enclosing an entire function in an
> > error context:
> >
> > @function_error_context('migration test')
> > def migration_test(...):
> > ...
>
> @context_aware does that, but it doesn't let you set the context string
> (it just initializes it to "(function_name)"). I think it is enough for
> our purposes (and it keeps the API simple).
>
> >
> > anything in migration_test() is enclosed in that context. But we're
> > just repeating the ordinary stack trace with something more
> > readable.
>
> The context information is more useful for cases we want to know where
> exactly we were, inside a single function (e.g. "did we crash before or
> after migration finished?"). So the API is optimized for the cases where
> we actually want to change the context string inside the same function.
>
Ok, makes sense. 'with' would have been nice, but I understand the need
for compatibility.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2011-01-05 16:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-05 15:45 [KVM-AUTOTEST PATCH v2 1/6] [RFC] Fix Unhandled* exceptions Michael Goldish
2011-01-05 15:45 ` [KVM-AUTOTEST PATCH v2 2/6] [RFC] CmdError: remove extra blank line between methods Michael Goldish
2011-01-05 15:45 ` [KVM-AUTOTEST PATCH v2 3/6] [RFC] Introduce exception context strings Michael Goldish
2011-01-05 15:54 ` Eduardo Habkost
2011-01-05 16:12 ` Avi Kivity
2011-01-05 16:21 ` Eduardo Habkost
2011-01-05 16:22 ` Avi Kivity
2011-01-05 18:55 ` Michael Goldish
2011-01-05 19:10 ` Eduardo Habkost
2011-01-05 16:21 ` Avi Kivity
2011-01-05 16:36 ` Eduardo Habkost
2011-01-05 16:39 ` Avi Kivity [this message]
2011-01-06 11:56 ` Michael Goldish
2011-01-05 15:45 ` [KVM-AUTOTEST PATCH v2 4/6] [RFC] Embed context information in exception strings Michael Goldish
2011-01-05 15:45 ` [KVM-AUTOTEST PATCH v2 5/6] [RFC] KVM test: use error.context() in migration_with_file_transfer Michael Goldish
2011-01-05 15:45 ` [KVM-AUTOTEST PATCH v2 6/6] [RFC] KVM test: use error.context() in kvm_preprocessing.py Michael Goldish
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D249EC7.2070204@redhat.com \
--to=avi@redhat.com \
--cc=autotest@test.kernel.org \
--cc=ehabkost@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mgoldish@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox