From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] pci-assign: Fix transition MSI->INTx Date: Thu, 06 Jan 2011 15:40:15 +0200 Message-ID: <4D25C63F.2020908@redhat.com> References: <4D238B5E.9010102@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm , Alex Williamson , "Michael S. Tsirkin" To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:5206 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751653Ab1AFNkU (ORCPT ); Thu, 6 Jan 2011 08:40:20 -0500 In-Reply-To: <4D238B5E.9010102@web.de> Sender: kvm-owner@vger.kernel.org List-ID: On 01/04/2011 11:04 PM, Jan Kiszka wrote: > From: Jan Kiszka > > Make sure to re-register the IRQ of an assigned device as INTx when the > guest disables MSI[X] mode again. > > Signed-off-by: Jan Kiszka Cc: More Reviewers > --- > hw/device-assignment.c | 6 ++++++ > 1 files changed, 6 insertions(+), 0 deletions(-) > > diff --git a/hw/device-assignment.c b/hw/device-assignment.c > index f6410f8..fce7567 100644 > --- a/hw/device-assignment.c > +++ b/hw/device-assignment.c > @@ -1192,7 +1192,10 @@ static void assigned_dev_update_msi(PCIDevice *pci_dev, unsigned int ctrl_pos) > if (kvm_assign_irq(kvm_context,&assigned_irq_data)< 0) > perror("assigned_dev_enable_msi: assign irq"); > > + assigned_dev->girq = -1; > assigned_dev->irq_requested_type = assigned_irq_data.flags; > + } else { > + assign_irq(assigned_dev); > } > } > #endif > @@ -1332,7 +1335,10 @@ static void assigned_dev_update_msix(PCIDevice *pci_dev, unsigned int ctrl_pos) > perror("assigned_dev_enable_msix: assign irq"); > return; > } > + assigned_dev->girq = -1; > assigned_dev->irq_requested_type = assigned_irq_data.flags; > + } else { > + assign_irq(assigned_dev); > } > } > #endif -- error compiling committee.c: too many arguments to function