qemu-kvm vs. qemu: Terminate cpu loop on reset?

[Jan Kiszka <jan.kiszka@web.de>]

[-- Attachment #1: Type: text/plain, Size: 655 bytes --]

Hi,

does anyone immediately know if this hunk from vl.c

@@ -1278,6 +1197,10 @@ void qemu_system_reset_request(void)
     } else {
         reset_requested = 1;
     }
+    if (cpu_single_env) {
+        cpu_single_env->stopped = 1;
+        cpu_exit(cpu_single_env);
+    }
     qemu_notify_event();
 }

is (semantically) relevant for upstream as well? IIUC, it ensures that
the kvm cpu loop is not continued if an IO access called into
qemu_system_reset_request.

If yes, then it would be a good time to push a patch: these bits will
fall to dust on next merge from upstream (vl.c no longer has access to
the cpu state).

Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]