From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [GIT PULL] KVM updates for the 2.6.38 merge window Date: Tue, 11 Jan 2011 11:25:18 +0200 Message-ID: <4D2C21FE.3000406@redhat.com> References: <4D2ACFA7.6000502@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , linux-kernel , KVM list To: Linus Torvalds Return-path: Received: from mx1.redhat.com ([209.132.183.28]:36923 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752515Ab1AKJZZ (ORCPT ); Tue, 11 Jan 2011 04:25:25 -0500 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On 01/10/2011 09:31 PM, Linus Torvalds wrote: > On Mon, Jan 10, 2011 at 1:21 AM, Avi Kivity wrote: > > > > - asynchronous page faults, which allow a guest to continue processing > > interrupts even when its memory is being paged in; in the case of a Linux > > 2.6.38+ guest, it will receive a notification that the host is servicing a > > page fault, and may switch into another guest process > > So quite frankly, I don't like how this was done. > > When you touch files like mm/memory.c, you don't just touch them. You > get sign-offs and acks from the VM maintainers. Seriously. > > In this case, I pulled, looked, and then unpulled. I just don't want > it, and I think the new FAULT_FLAG_MINOR is seriously mis-named and > hacky. > > Is it about atomicity? Is it about IO? IO. It means, only allow a minor fault; fail for a major fault. Can you suggest a better name? > Why wasn't I notified > before-hand? Was Andrew cc'd? Andrew and linux-mm were copied. Rik was the only one who reviewed (and ack'ed) it. I guess I should have explicitly asked for Nick's review. How do you want to proceed? I can pull this patch out and stub out the callers in kvm (which will neuter async page faults for the time being, but we can live with that), then fix it in the background, or we can try to resolve it now. What are your issues with the patch? -- error compiling committee.c: too many arguments to function