From mboxrd@z Thu Jan 1 00:00:00 1970 From: Xiao Guangrong Subject: Re: [PATCH v3 1/3] KVM: fix rcu usage warning in kvm_arch_vcpu_ioctl_set_sregs() Date: Thu, 27 Jan 2011 10:35:35 +0800 Message-ID: <4D40D9F7.6000006@cn.fujitsu.com> References: <4D2D5AA6.9080804@cn.fujitsu.com> <4D3673A7.4090402@cn.fujitsu.com> <20110119181347.GA13142@amt.cnet> <4D37A603.4040602@cn.fujitsu.com> <20110120152736.GA3922@amt.cnet> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: Avi Kivity , LKML , KVM To: Marcelo Tosatti Return-path: In-Reply-To: <20110120152736.GA3922@amt.cnet> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 01/20/2011 11:27 PM, Marcelo Tosatti wrote: >> Sure :-), there is the simply test result of kernbench: >> >> Before patch: >> >> real 5m6.493s >> user 3m57.847s >> sys 9m7.115s >> >> real 5m1.750s >> user 4m0.109s >> sys 9m10.192s >> >> >> After patch: >> real 5m0.140s >> user 3m57.956s >> sys 8m58.339s >> >> real 4m56.314s >> user 4m0.303s >> sys 8m55.774s > > Nice. One disadvantageous side effect for the kvm_vcpu_kick path > is that it can race with make_all_cpus_request, which is possibly > doing unrelated, slower work (IPI'ing other vcpus, waiting for > response). > > Looks ok, but lets wait for more careful reviews before applying. > Hi Avi, Marcelo, I shall on vacation from 1.25 to 2.9, if you have comments on it i'll replay after coming back. :-)